Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bevy to 0.11 and iced to 0.10 #18

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Conversation

jsatka
Copy link
Contributor

@jsatka jsatka commented Jul 18, 2023

Currently all iced crate dependencies have to point to a recent master branch revision until version 0.10 is released with wgpu version 0.16, on which bevy 0.11 depens on.

Tested that all checks pass on Ubuntu and all three examples run as expected.

@jsatka
Copy link
Contributor Author

jsatka commented Jul 18, 2023

I am not yet sure if more iced sub-crate types would need to be re-exported with pub in order to utilize all features of iced. Any thoughts are welcome.

@jsatka jsatka mentioned this pull request Jul 18, 2023
@tasgon
Copy link
Owner

tasgon commented Jul 29, 2023

If you don't mind, why did you decide to add the fonts example?

@EmperialDev
Copy link
Contributor

I actually think it's a good idea to have a font example, it took me a long time to find out how to use a font with bevy_iced and iced 0.9, and I actually thougt it was nearly impossible to do so on iced 0.10. So I think ist's a great help to beginners.

@jsatka
Copy link
Contributor Author

jsatka commented Jul 31, 2023

If you don't mind, why did you decide to add the fonts example?

Sure! Happy to discuss any other changes, too, if there's anything that doesn't seem like an obvious choice to other collaborators or users.

I thought it may not be obvious, with beginners in mind as @EmperialDev pointed out, how to include own fonts because they have to be included as static byte arrays, which differs from Bevy's native UI primary way of loading fonts via the AssetServer. Therefore I believed it could be a time-saver for some beginners.

@jsatka jsatka changed the title Upgrade bevy to 0.11 Upgrade bevy to 0.11 and iced to 0.10 Jul 31, 2023
@tasgon
Copy link
Owner

tasgon commented Jul 31, 2023

Thinking about it more, I see the rationality, but I think we should instead create a custom asset loader for iced fonts instead of having to statically include them into the binary. That way, multiple assets can be used without making the binary balloon into massive sizes and it gives game developers the option of allowing user-replaceable fonts. What do you think?

@jsatka
Copy link
Contributor Author

jsatka commented Aug 1, 2023

Custom asset loader would be great, if not essential, for image assets and I am all for it!

But with fonts only I'd think that static inclusion would be enough for a vast majority of game developers. On one hand, I have a hard time thinking about a game where it'd be necessary or useful for players to be able to play around with the fonts. But on the other hand, I know Bevy can be and is being used to develop other kinds of apps, too, so the added flexibility wouldn't hurt.

@tasgon
Copy link
Owner

tasgon commented Aug 1, 2023

I have a hard time thinking about a game where it'd be necessary or useful for players to be able to play around with the fonts.

Games that support custom skins/texture packs come to mind, such as Minecraft or TF2. Looking at the code, though, it might be a bit annoying, so I'll probably just accept this as-is, but I will change the example to instead load the font from a file at start time rather than statically including it into the binary.

@tadeohepperle
Copy link

Hey guys, I would be very thankful if we could get this merged into the master branch soon :)

@tasgon tasgon mentioned this pull request Aug 9, 2023
@tasgon tasgon merged commit f2ca2b4 into tasgon:master Aug 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants